fold 'kola testiso' into 'kola run' #4377
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
'metal.go' is only used by testiso and contains code&data structures similar to those provided by 'machines/qemu/*.go'.
These checks are already performed by harness.go:CheckConsole.
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request is a large but valuable refactoring that folds the kola testiso command into kola run. This improves the consistency and maintainability of the test suite. The implementation moves the ISO test logic into a new mantle/kola/tests/iso package and refactors the QEMU cluster platform API to be more extensible and modular, which is a great improvement.
I've found a few issues that could be improved:
- There are a couple of places where
panic()is used inside a goroutine for error handling, which can crash the entire test runner. It would be better to handle these errors more gracefully, for example by logging them. - There is a potential goroutine leak in the
awaitCompletionhelper function due to atime.Sleepthat doesn't respect context cancellation. - A file path is constructed using
strings.Replace, which is fragile. Using thepath/filepathpackage would be more robust.
Overall, this is a solid refactoring. My comments are focused on improving robustness and resource management.
Contributor
Author
|
It's not yet 100% ready - i'm reworking metal PXE&ISO installation, so those tests still rely on code from |
nikita-dubrovskii
force-pushed
the
fold_testiso
branch
from
ba29c71 to
be43927
Compare
nikita-dubrovskii
force-pushed
the
fold_testiso
branch
from
be43927 to
9499239
Compare
nikita-dubrovskii
force-pushed
the
fold_testiso
branch
from
9499239 to
9816db6
Compare
nikita-dubrovskii
changed the title
Contributor
Author
|
Finished metal PXE&ISO installation. Almost ready for review. |
The iso.* tests use systemd units that report success or failure via virtio channels and always power off the machine. Because of this, we do not need to SSH into the instance or check Ignition errors.
nikita-dubrovskii
force-pushed
the
fold_testiso
branch
from
34d0988 to
ac38a76
Compare
Contributor
Author
|
s390x run: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This huge PR folds all
testisotests:#3989